[Fizz][Float] emit viewport meta before preloads #27201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the proper resolution loaded in some cases. This change updates our queueing strategy to utilize our preconnect queue for the viewport meta tag
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 997f52f...bc15396 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Aug 7, 2023
|
Yes probably. I considered it for this PR but I think I want to rename them all. I don't want to just end up with super high, high, medium, low etc... so using what they are for is nice. In reality I could have created a separate queue and just put it after (or before) preconnects but the order isn't important between these sets and it is slightly more effecient to keep them together. I'll think about a broader rename as I land the other PRs that affect our queues |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Fixes: #27200 preloads for images that appear before the viewport meta may be loaded twice because the proper device image information is not used with the preload but is with the image itself. The viewport meta should be emitted earlier than all preloads to avoid this. this change moves the queue for the viewport meta to preconnects which already has the right priority for this tag DiffTrain build for [ea17cc1](ea17cc1)
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 8, 2023
Updated React from 9377e1010 to cb3404a0c. ### React upstream changes - facebook/react#27190 - facebook/react#27189 - facebook/react#27201 - facebook/react#27147 - facebook/react#26949 - facebook/react#27058 - facebook/react#27142 - facebook/react#27133 - facebook/react#27130 - facebook/react#27105 - facebook/react#27117 - facebook/react#27057
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 8, 2023
…#53700) The root cause is `ReactDOM.preload()` inserts `<link rel="preload">` above the `<meta name="viewport">`. This PR adds a test to prove that upgrading React fixes the issue (see commits). - Depends on facebook/react#27201 - Depends on #53742 - Fixes #53574 - Related #52995
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Fixes: facebook#27200 preloads for images that appear before the viewport meta may be loaded twice because the proper device image information is not used with the preload but is with the image itself. The viewport meta should be emitted earlier than all preloads to avoid this. this change moves the queue for the viewport meta to preconnects which already has the right priority for this tag
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
Fixes: #27200 preloads for images that appear before the viewport meta may be loaded twice because the proper device image information is not used with the preload but is with the image itself. The viewport meta should be emitted earlier than all preloads to avoid this. this change moves the queue for the viewport meta to preconnects which already has the right priority for this tag DiffTrain build for commit ea17cc1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #27200
preloads for images that appear before the viewport meta may be loaded twice because the proper device image information is not used with the preload but is with the image itself. The viewport meta should be emitted earlier than all preloads to avoid this.
this change moves the queue for the viewport meta to preconnects which already has the right priority for this tag