Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced the custom clz32 function with Math.clz32 #27206

Closed
wants to merge 4 commits into from

Conversation

girishsontakke
Copy link

Summary

Math.clz32 is API is supported by almost all the browsers and node12+. So we should replace the custom clz32 function with the Math.clz32 function.
Screenshot 2023-08-09 at 10 13 17

@react-sizebot
Copy link

react-sizebot commented Aug 9, 2023

Comparing: 3808b01...59c3063

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 165.63 kB 165.59 kB = 51.88 kB 51.84 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 174.70 kB 174.67 kB = 54.61 kB 54.57 kB
facebook-www/ReactDOM-prod.classic.js = 570.44 kB 570.45 kB = 100.45 kB 100.43 kB
facebook-www/ReactDOM-prod.modern.js = 554.21 kB 554.23 kB = 97.61 kB 97.59 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server.development.js = 154.42 kB 153.98 kB = 38.71 kB 38.55 kB
oss-stable-semver/react-server/cjs/react-server.development.js = 148.43 kB 147.99 kB = 36.97 kB 36.82 kB
oss-stable/react-server/cjs/react-server.development.js = 148.43 kB 147.99 kB = 36.97 kB 36.82 kB
oss-experimental/react-server/cjs/react-server.production.min.js = 26.36 kB 26.28 kB = 8.96 kB 8.91 kB
oss-stable-semver/react-server/cjs/react-server.production.min.js = 25.52 kB 25.44 kB = 8.67 kB 8.61 kB
oss-stable/react-server/cjs/react-server.production.min.js = 25.52 kB 25.44 kB = 8.67 kB 8.61 kB

Generated by 🚫 dangerJS against 59c3063

Copy link

github-actions bot commented Apr 7, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 7, 2024
Copy link

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions bot closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants