Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgot to gate pushImg #27212

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Forgot to gate pushImg #27212

merged 1 commit into from
Aug 10, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Aug 10, 2023 •
edited

pushImg should have been gated by enableFloat

Added in #27191

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 10, 2023
@gnoff gnoff requested a review from sebmarkbage August 10, 2023 23:17
@react-sizebot
Copy link

Comparing: f359f9b...56abd7a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.32 kB 164.32 kB = 51.76 kB 51.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.74 kB 171.74 kB = 53.98 kB 53.98 kB
facebook-www/ReactDOM-prod.classic.js = 567.12 kB 567.12 kB = 100.09 kB 100.09 kB
facebook-www/ReactDOM-prod.modern.js = 550.92 kB 550.92 kB = 97.25 kB 97.25 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 56abd7a

@gnoff gnoff merged commit 533fc28 into facebook:main Aug 10, 2023
36 checks passed
@gnoff gnoff deleted the img-fix branch August 10, 2023 23:42
@gnoff gnoff mentioned this pull request Aug 12, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Aug 12, 2023
@gnoff
Update React ot latest canary (#53881)
2b38118 
Updated React from cb3404a0c to f359f9b41.

### React upstream changes

- facebook/react#27191
- facebook/react#27209
- facebook/react#27199
- facebook/react#27218
- facebook/react#27217
- facebook/react#27212
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gnoff @AndyPengc12
Forgot to gate pushImg (facebook#27212)
1b1c068 
`pushImg` should have been gated by enableFloat

Added in facebook#27191
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@gnoff
Forgot to gate pushImg (#27212)
63048d5 
`pushImg` should have been gated by enableFloat

Added in #27191

DiffTrain build for commit 533fc28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnoff @react-sizebot @facebook-github-bot