Add server.edge to react-server-dom-esm
#27353
Open
+192
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregBrimble
force-pushed
the
react-server-dom-esm-server-edge
branch
from
f46b6ca
to
f153888
Compare
GregBrimble
force-pushed
the
react-server-dom-esm-server-edge
branch
2 times, most recently
from
0e135ef
to
f7f266e
Compare
GregBrimble
commented
Sep 10, 2023
GregBrimble
force-pushed
the
react-server-dom-esm-server-edge
branch
5 times, most recently
from
e4b9512
to
c136ff5
Compare
GregBrimble
force-pushed
the
react-server-dom-esm-server-edge
branch
from
c136ff5
to
cd16c3d
Compare
|
Ran into this limitation the other day also, would be great if this (or a similar) implementation could land in main! |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
|
Bump |
github-actions
bot
removed
the
Resolution: Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
React Server DOM webpack has both a Node.js and a Edge server, but React Server DOM ESM only had a Node.js server. This PR adds a Edge server for React Server DOM ESM.
How did you test this change?
Doesn't look like React Server DOM ESM has any tests yet. Happy to try adding some, but that might make more sense in a different PR. Let me know what y'all think.
Locally, I have a hacked together fixture based on flight-esm which shows this working in workerd (the Cloudflare Workers runtime). Also happy to share that if that helps validate this PR.