Land enableCustomElementPropertySupport for React 19 #27450
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: a73c345...670c7fa Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Can we just delete the flag? |
Yeah, I guess we could do that. |
alunyov
changed the title
|
There's a known issue with this flag here: #27286 |
alunyov
force-pushed
the
enableCustomElementPropertySupport
branch
from
4840175
to
660a689
Compare
|
just pinging this thread to see if there are any barriers to getting this merged? This PR is a clear signal of web component support in react and a lot of web components advocates are eagerly awaiting :) |
|
@michaelwarren1106 our plan is to include this in our next stable release which is being put together now. It will be merged closer to when we are ready to publish |
|
@gnoff While your comment above gives me some hope, I still find myself wondering if I actually understand what to expect in the next stable release. Is there a roadmap published with the contents of the next stable release somewhere? I could not find anything myself; I have some older information about what you're working on but I don't consider everything I read to be a commitment or a comprehensive list (and support for custom element support is never mentioned). To be honest monitoring GitHub threads (like this one) for the last several years has been frustrating and confusing. Will the React team please state plainly what to expect regarding support for custom elements in a blog post here: react.dev/blog? As evidence that there is tremendous appetite for this content I will mention this relates to the #2 most discussed issue and the most hearted issue (it's the same) in the list of public React issues (issue locked since Oct 2023). What I think I can expect is that the next major release will show all 32 basic & advanced tests on custom-elements-everywhere.com to be passing in an upcoming stable React release. Today this is true for Sorry for the rant; I do appreciate the React team's efforts! Also 👋🏻 @poteto — it's good to see a familiar face working on this :) |
|
@klebba we're finalizing the release and then we'll be able to share what's in it. For custom elements, since this PR turns the flag on from |
|
Hi @rickhanlonii — thanks for your reply. I'll reiterate what I'm asking, I don't intend to be controversial and only want to know about this subject:
What exactly does this flag do? What does it not do? I still hope the React team will soon state plainly what to expect regarding support for custom elements in a blog post here: react.dev/blog. To be clear, I'm not asking:
I'm recommending:
So that I can have:
My dream would be to read a blog post on react.dev/blog along these lines:
Thanks for your time and effort! |
|
@klebba I posted an update in #11347 (comment), we'll share updates on the blog when we share more about the next release. |
|
Thank you @rickhanlonii — I really appreciate the clarity! |
rickhanlonii
force-pushed
the
enableCustomElementPropertySupport
branch
from
660a689
to
7287509
Compare
|
Rebased on main |
rickhanlonii
changed the title
rickhanlonii
force-pushed
the
enableCustomElementPropertySupport
branch
from
7287509
to
670c7fa
Compare
We've rolled out this flag internally on WWW. This PR removed flag `enableCustomElementPropertySupport` Test plan: -- `yarn test` Co-authored-by: Ricky Hanlon <rickhanlonii@gmail.com>
We've rolled out this flag internally on WWW. This PR removed flag
enableCustomElementPropertySupportTest plan:
--
yarn test