Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validateDOMNesting: Allow hr as child of select #27632

Merged
merged 2 commits into from
Oct 31, 2023
Merged

validateDOMNesting: Allow hr as child of select #27632

merged 2 commits into from
Oct 31, 2023

Conversation

SouSingh
Copy link
Contributor

fix #27572

@react-sizebot
Copy link

react-sizebot commented Oct 31, 2023 •
edited

Comparing: 0c63487...9ef29fb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.09 kB 175.09 kB = 54.48 kB 54.47 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.21 kB 177.21 kB = 55.16 kB 55.16 kB
facebook-www/ReactDOM-prod.classic.js = 567.70 kB 567.70 kB = 99.96 kB 99.96 kB
facebook-www/ReactDOM-prod.modern.js = 551.56 kB 551.56 kB = 97.06 kB 97.06 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 9ef29fb

@philwolstenholme
Copy link

@sophiebits, @SouSingh got to this before I did :)

(re: #27572)

sophiebits
sophiebits approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@sophiebits sophiebits changed the title Update validateDOMNesting.js validateDOMNesting: Allow hr as child of select Oct 31, 2023
@sophiebits sophiebits merged commit ca16c26 into facebook:main Oct 31, 2023
2 of 23 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
@sophiebits
validateDOMNesting: Allow hr as child of select (#27632)
8c6e716 
fix #27572

---------

Co-authored-by: Sophie Alpert <git@sophiebits.com>

DiffTrain build for [ca16c26](ca16c26)
@ztanner ztanner mentioned this pull request Nov 1, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Nov 1, 2023
@ztanner
Update React from 0c6348758 to 08a39539f (#57852)
c82f6a8 
Updates React from 0c6348758 to 08a39539f.

### React upstream changes

- facebook/react#27634
- facebook/react#27632
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@SouSingh @sophiebits @AndyPengc12
validateDOMNesting: Allow hr as child of select (facebook#27632)
25bf50b 
fix facebook#27572

---------

Co-authored-by: Sophie Alpert <git@sophiebits.com>
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@sophiebits
validateDOMNesting: Allow hr as child of select (#27632)
3f8dff1 
fix #27572

---------

Co-authored-by: Sophie Alpert <git@sophiebits.com>

DiffTrain build for commit ca16c26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiebits sophiebits sophiebits approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: 'Warning: validateDOMNesting: <hr> cannot appear as a child of <select>' – but this is now valid HTML
5 participants
@SouSingh @react-sizebot @philwolstenholme @sophiebits @facebook-github-bot