Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flag: disableModulePatternComponents #27730

Closed

Conversation

kassens
Copy link
Member

@kassens kassens commented Nov 20, 2023

Enables the flag disableModulePatternComponents which disables a very old pattern of rendering a function that returns a class component. This was already warning before, but now it would stop working.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 20, 2023
@kassens kassens requested a review from gnoff November 21, 2023 21:49
@kassens kassens force-pushed the disableModulePatternComponents branch from 860e614 to 43cfc42 Compare November 22, 2023 18:10
@gnoff
Copy link
Collaborator

gnoff commented Nov 27, 2023

@kassens I went a little further here: #27742

@kassens
Copy link
Member Author

kassens commented Nov 27, 2023

Awesome

@kassens kassens closed this Nov 27, 2023
@kassens kassens deleted the disableModulePatternComponents branch November 27, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants