New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fizz] Only compute component stacks in DEV and prerenders #27850
Merged
sebmarkbage
merged 1 commit into
facebook:main
from
sebmarkbage:rmcomponentstacksinprod
Dec 19, 2023
Merged
[Fizz] Only compute component stacks in DEV and prerenders #27850
sebmarkbage
merged 1 commit into
facebook:main
from
sebmarkbage:rmcomponentstacksinprod
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Dec 19, 2023
sebmarkbage
force-pushed
the
rmcomponentstacksinprod
branch
from
December 19, 2023 22:54
de0af49
to
6b5f003
Compare
josephsavona
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the quick fix!
Comparing: cb24396...2b9fd01 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
force-pushed
the
rmcomponentstacksinprod
branch
from
December 19, 2023 22:59
6b5f003
to
2b9fd01
Compare
acdlite
added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2024
### React upstream changes - facebook/react#27888 - facebook/react#27870 - facebook/react#27871 - facebook/react#27850 - facebook/react#27839 - facebook/react#27842 - facebook/react#27841 - facebook/react#27840 - facebook/react#27761 - facebook/react#27831 - facebook/react#27801 Closes NEXT-2012
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…27850) If you have a lot of intentional throws (or postpones) from client-only rendering then computing the stack is too much.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
If you have a lot of intentional throws (or postpones) from client-only rendering then computing the stack is too much. DiffTrain build for commit c5b9375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a lot of intentional throws (or postpones) from client-only rendering then computing the stack is too much.