-
Notifications
You must be signed in to change notification settings - Fork 45.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: [Windows OS Only] yarn test returns stderr: file not found for 2 files #27890
Conversation
Hi @schulerj89! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Comparing: 1d5667a...c1c8c94 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Hm, is there a way to fix this by keeping the and not using the relative path? What's the path it's actually using? |
It's just trying to get to the root directory but yarn.cmd isn't able to resolve the variable. It's the only test file that I saw that even used it this way. I also checked other areas in the code that referenced the scripts folder in the same way. It's only an issue for windows but those using windows can't run yarn test out of the box. |
@rickhanlonii just keeping this on your radar. |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Summary
Fixes a bug with running
yarn test
on a Windows OS #26212. I ran across the same issue on my Windows OS using PowerShell and Command Prompt.Steps to reproduce:
git clone
the react repositorymain
branch on Windows OSyarn
yarn test ReactClassEquivalence
oryarn test
How did you test this change?
yarn test ReactClassEquivalence
oryarn test
Before the fix
After the fix