Convert findDOMNode-test.js to createRoot #28119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
mattcarrollcode
commented
Jan 26, 2024
| @@ -11,7 +11,9 @@ | |||
|
|
|||
| const React = require('react'); | |||
| const ReactDOM = require('react-dom'); | |||
| const ReactDOMClient = require('react-dom/client'); | |||
| const ReactTestUtils = require('react-dom/test-utils'); | |||
There was a problem hiding this comment.
Should I refactor this test to remove ReactTestUtils?
|
Comparing: 7c79daf...e79afde Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
mattcarrollcode
commented
Jan 26, 2024
| root.render(<MyNode flag={true} ref={nodeRef} />); | ||
| }); | ||
| const nodeAfterUpdate = nodeRef.current; | ||
| expect(nodeAfterInitialRender === nodeAfterUpdate).toBe(true); |
There was a problem hiding this comment.
I'm not 100% sure that this is equivalent to the previous version of the test.
Previous version:
nodeA = ReactDOM.render(<Component>)
nodeB = ReactDOM.render(<UpdatedComponent>)
assert(nodeA === nodeB)
this version:
const ref = React.createRef()
root.render(<Something ref={ref} />)
const componentAfterInitialRender = ref.current
root.render(<UpdatedSomething ref={ref} />)
const componentAfterUpdate= ref.current
assert(componentAfterInitialRender === componentAfterUpdate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.