[Devtools] Add React Conf banner in component inspector panel #28414
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
hoxyq
reviewed
Feb 22, 2024
Comment on lines
+23
to
+28
| chrome.storage.local.get(['bannerClosed']).then(result => { | ||
| if (result.bannerClosed) { | ||
| const banner = document.querySelector('.dismissable-banner'); | ||
| banner.remove(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Since storage.local.get is asynchronous, this will probably leave the banner on the screen for a couple of milliseconds?
Can we actually do the opposite thing here? Instead of hiding based on the flag from storage, can we show the banner, if there is no bannerClosed flag in storage?
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dismissable React Conf banner to the DevTools extension. One dismissed the banner will not reappear and the banner will automatically disappear after React Conf is over (React Conf is happening from May 15-16th).