Add type to root, remove OpaqueRoot. #28416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently read the React source code, and have a few suggestions to improve the reading experience. Hope you can consider them ~ 1. Every time I see the assignment of root in the createRoot function, I often can't remember the type of this value for a moment, so I think maybe adding a type here would be helpful. 2. OpaqueRoot is actually FiberRoot, so there's no need to define another name for it here, right? It's not very good for the reading experience~
As before, add type annotations to the root.
As before, add type annotations.
As before, add annotations.
As before, add annotations.
|
There's a point to the separate name. It's also supposed to be an It's because the outside of this shouldn't know whether it's a FiberRoot or not. It is today but after an internal refactor of the implementation details it wouldn't be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently read the React source code, and have a few suggestions to improve the reading experience. Hope you can consider them ~