Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move string ref coercion to JSX runtime #28473

Merged
merged 1 commit into from
Apr 5, 2024

Commits on Apr 4, 2024

  1. Move string ref coercion to JSX runtime

    This moves the entire string ref implementation out Fiber and into
    the JSX runtime. The string is converted to a callback ref during
    element creation. This is a subtle change in behavior, because it will
    have already been converted to a callback ref if you access
    element.prop.ref or element.ref. But this is only for Meta, because
    string refs are disabled entirely in open source. And if it leads to
    an issue in practice, the solution is to switch to a different ref type,
    which Meta is going to do regardless.
    acdlite committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    880ccbd View commit details
    Browse the repository at this point in the history