Test for overlapping optimistic updates #28575
Open
+135
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
commented
Mar 18, 2024
| @@ -822,6 +822,141 @@ describe('ReactAsyncActions', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| // @gate enableAsyncActions | |||
| test('useOptimistic rebases pending updates while dropping finished updates on top of passthrough value', async () => { | |||
There was a problem hiding this comment.
It's currently not dropping the finished updates but should as far as I can tell.
|
Comparing: 9ffe910...080f45b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
force-pushed
the
overlapping-opimistic-updates
branch
from
c336198
to
18f7614
Compare
eps1lon
force-pushed
the
overlapping-opimistic-updates
branch
from
18f7614
to
080f45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for the code authored in #28574