Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gating for alwaysThrottleDisappearingFallbacks #28629

Closed
wants to merge 1 commit into from

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Mar 25, 2024

If you turn off these flags independently:

  • alwaysThrottleDisappearingFallbacks
  • alwaysThrottleRetries

You'll see that this behavior only works if both flags are enabled. I updated the flags with the correct gating.

Alternatively, we could fix the behavior: #28630

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 25, 2024
@react-sizebot
Copy link

Comparing: 5a75f9e...5dbe02c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.93 kB 176.93 kB = 54.95 kB 54.95 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.36 kB 173.36 kB = 54.08 kB 54.08 kB
facebook-www/ReactDOM-prod.classic.js = 595.27 kB 595.27 kB = 104.55 kB 104.55 kB
facebook-www/ReactDOM-prod.modern.js = 578.53 kB 578.53 kB = 101.57 kB 101.57 kB
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Generated by 🚫 dangerJS against 5dbe02c

@rickhanlonii
Copy link
Member Author

Closed by #28639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants