Don't log onRecoverableError if the current commit fail #28665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 323b6e9...493035b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
force-pushed
the
recoverableerrors
branch
2 times, most recently
from
b6bde0a
to
db7f18d
Compare
sebmarkbage
commented
Mar 28, 2024
| const reportedClientErrors = []; | ||
| ReactDOMClient.hydrateRoot(container, <App />, { | ||
| onCaughtError(error) { |
There was a problem hiding this comment.
I'm kind of confused why the lack of this override didn't fail the test before because it should've logged to console.error which fails the test.
We didn't recover after all.
sebmarkbage
force-pushed
the
recoverableerrors
branch
from
db7f18d
to
493035b
Compare
acdlite
approved these changes
Mar 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
We didn't recover after all. Currently we might log a recoverable error in the recovery pass. E.g. the SSR server had an error. Then the client component fails to render which errors again. This ends up double logging. So if we fail to actually complete a fully successful commit, we ignore any recoverable errors because we'll get real errors logged. It's possible that this might cover up some other error that happened at the same time. DiffTrain build for [e10a7b5](e10a7b5)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
We didn't recover after all. Currently we might log a recoverable error in the recovery pass. E.g. the SSR server had an error. Then the client component fails to render which errors again. This ends up double logging. So if we fail to actually complete a fully successful commit, we ignore any recoverable errors because we'll get real errors logged. It's possible that this might cover up some other error that happened at the same time.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
We didn't recover after all. Currently we might log a recoverable error in the recovery pass. E.g. the SSR server had an error. Then the client component fails to render which errors again. This ends up double logging. So if we fail to actually complete a fully successful commit, we ignore any recoverable errors because we'll get real errors logged. It's possible that this might cover up some other error that happened at the same time. DiffTrain build for commit e10a7b5.
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't recover after all.
Currently we might log a recoverable error in the recovery pass. E.g. the SSR server had an error. Then the client component fails to render which errors again. This ends up double logging.
So if we fail to actually complete a fully successful commit, we ignore any recoverable errors because we'll get real errors logged.
It's possible that this might cover up some other error that happened at the same time.