Suppress console output in unit tests #28680
Merged
+34
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungsters
force-pushed
the
shhh
branch
2 times, most recently
from
0c304e4
to
063acb5
Compare
|
Comparing: 2aed507...6584708 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Ideally we'd fix these tests to no longer log so that we can instead assert (maybe only in CI) that tests don't call console.log. |
sebmarkbage
approved these changes
Mar 30, 2024
|
Agreed! But until then, I think this is incrementally better. (We already mock and suppress logs like this in other tests.) |
|
Followup here: #28693 Two of these are specifically testing console.log behavior, but we can fix one of them to not use console.log. |
rickhanlonii
added a commit
that referenced
this pull request
Apr 1, 2024
Followups to #28680 One of these test don't need to use `console.log`. The others are specifically testing `console.log` behavior, so I added a comment.
|
Followup to disallow unasserted console.log in CI here: #28708 |
rickhanlonii
added a commit
that referenced
this pull request
Apr 1, 2024
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Followups to facebook#28680 One of these test don't need to use `console.log`. The others are specifically testing `console.log` behavior, so I added a comment.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Followup from facebook#28693 and facebook#28680. In CI, we fail the test for any unasserted console.log. In DEV, we don't fail, but you can still use the matchers and we'll assert on them.
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes all unit tests that were spewing console output via
console.logto no longer do so.This will help reduce logspew and simplify parsing the reported Jest results.
How did you test this change?
See no more logspew when running unit tests.