Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic www flag for disableInputAttributeSyncing #28703

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 1, 2024

Remove dynamic www flag for disableInputAttributeSyncing

@react-sizebot
Copy link

react-sizebot commented Apr 1, 2024

Comparing: 8833338...57b6501

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 177.10 kB = 55.05 kB 55.05 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.94 kB 172.94 kB = 53.91 kB 53.91 kB
facebook-www/ReactDOM-prod.classic.js = 592.68 kB 591.73 kB = 103.96 kB 103.79 kB
facebook-www/ReactDOM-prod.modern.js = 574.37 kB 573.42 kB = 100.98 kB 100.83 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against 57b6501

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either remove the flag or ensure that there is still at least one test run with the flag on

@kassens
Copy link
Member Author

kassens commented Apr 2, 2024

Updated to still run the test at runtime.

@kassens kassens merged commit 7659c4d into facebook:main Apr 2, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 2, 2024
Remove dynamic www flag for disableInputAttributeSyncing

DiffTrain build for [7659c4d](7659c4d)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
)

Remove dynamic www flag for disableInputAttributeSyncing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants