Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nvmrc to Node.js v18 #28707

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Bump nvmrc to Node.js v18 #28707

merged 1 commit into from
Apr 2, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 1, 2024

Bump nvmrc to Node.js v18

Node.js v16 is long deprecated, seems like for v20 there's some more stuff to fix.


Stack created with Sapling. Best reviewed with ReviewStack.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 1, 2024
@kassens
Copy link
Member Author

kassens commented Apr 1, 2024

I think this might fix the build issues from #28704.

@react-sizebot
Copy link

react-sizebot commented Apr 1, 2024

Comparing: 6e65010...8138d81

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 177.10 kB = 55.05 kB 55.05 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.94 kB 172.94 kB = 53.91 kB 53.91 kB
facebook-www/ReactDOM-prod.classic.js = 592.68 kB 592.68 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 574.37 kB 574.37 kB = 100.98 kB 100.98 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against 8138d81

@kassens kassens changed the title Bump nvmrc to Node.js v20.12.0 Bump nvmrc to Node.js v20.x Apr 1, 2024
@kassens kassens changed the title Bump nvmrc to Node.js v20.x Bump nvmrc to Node.js v18 Apr 1, 2024
@kassens
Copy link
Member Author

kassens commented Apr 1, 2024

v20 causes other failures… trying 18 for now as a smaller step upgrade.

Node.js v16 is long deprecated, seems like for v20 there's some more stuff to fix.
@kassens kassens merged commit 4eb241a into facebook:main Apr 2, 2024
38 checks passed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Bump nvmrc to Node.js v18

Node.js v16 is long deprecated, seems like for v20 there's some more
stuff to fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants