[FB] use modern entrypoint in tests #28724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
force-pushed
the
www-modern-disable-legacy
branch
from
62f8e34
to
d16d5ca
Compare
gnoff
commented
Apr 3, 2024
packages/react-reconciler/src/__tests__/ReactScope-test.internal.js
Outdated
Show resolved
Hide resolved
gnoff
commented
Apr 3, 2024
sebmarkbage
reviewed
Apr 3, 2024
| @@ -430,6 +431,7 @@ describe('ReactScope', () => { | |||
| }); | |||
|
|
|||
| // @gate www | |||
| // @gate !disableLegacyMode | |||
There was a problem hiding this comment.
Need to rebase since I updated these to concurrent mode.
|
Comparing: 8f55a6a...bf5292b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
gnoff
force-pushed
the
www-modern-disable-legacy
branch
from
d16d5ca
to
fb33355
Compare
gnoff
changed the title
sebmarkbage
approved these changes
Apr 3, 2024
gnoff
force-pushed
the
www-modern-disable-legacy
branch
3 times, most recently
from
f40827b
to
f891aa9
Compare
gnoff
commented
Apr 3, 2024
| @@ -48,10 +49,10 @@ export { | |||
| useLayoutEffect, | |||
| useMemo, | |||
| useOptimistic, | |||
| useSyncExternalStore, | |||
There was a problem hiding this comment.
cleaning up the order to match react/index
| @@ -33,6 +33,7 @@ export { | |||
| unstable_Activity, | |||
| unstable_Scope, | |||
| unstable_SuspenseList, | |||
| unstable_TracingMarker, | |||
There was a problem hiding this comment.
this was missing from the modern entrypoint but is necessary for tracing tests to pass. Curious though that it doesn't fail. probably because it's a symbol and it imports in cjs as undefined
gnoff
force-pushed
the
www-modern-disable-legacy
branch
from
f891aa9
to
8aebb2f
Compare
Disables legacy mode in www-modern and removes the entrypoint hack in tests since we gate legacy mode tests now Additionally disables test utils because this relies on legacy mode. Additionally gates react-test-renderer test for unstable_Scope because it seems to also rely on legacy roots.
gnoff
force-pushed
the
www-modern-disable-legacy
branch
from
8aebb2f
to
bf5292b
Compare
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Removes the entrypoint hack in tests since we gate legacy mode tests now
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
Removes the entrypoint hack in tests since we gate legacy mode tests now DiffTrain build for commit cb6dc7a.
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the entrypoint hack in tests since we gate legacy mode tests now