CI: Run with Node.js 18.20 #28774
Merged
CI: Run with Node.js 18.20 #28774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimg/openjdk has no version satisfying Node.js ^18.18 which we need for ESLint v9. We can only choose between 18.13 (too low) and 20.x. 20.x might be an alternative but means we no longer test the lowest Node.js LTS release.
|
Comparing: 2acfb7b...3fc57bc Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
facebook-github-bot
added
the
React Core Team
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 11, 2024
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 11, 2024
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Run CI with Node.js 18.20.1 instead of 16.16.0. Node.js 16.x has reached end-of-life. Codesandbox and local development already use 18.x due to
.nvmrcanyway.cimg/openjdk has no version satisfying Node.js ^18.18 which we need for ESLint v9. However, cimg/node does have Java 11 (which is sufficient for GCC). We can only choose between Node.js 18.13 (too low) and Node.js 20.x when using cimg/openjdk. Using Node.js 20.x would be an alternative but means we no longer test the lowest Node.js LTS release.
cimg/node-browsers is also just 170MB instead of 530MB that cimg/openjdk uses which is nice.
How did you test this change?