Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOM] Fix package.json files for #28784 #28785

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[DOM] Fix package.json files for #28784 #28785

merged 1 commit into from
Apr 8, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 8, 2024

Missed some files for the react-server disallow client change in #28784

@gnoff gnoff requested a review from sebmarkbage April 8, 2024 22:41
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 8, 2024
gnoff
gnoff commented Apr 8, 2024
View reviewed changes
packages/react-dom/package.json
"test-utils.js",
"unstable_testing.js",
"unstable_testing.react-server.js",
"unstable_server-external-runtime.js",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ordering to match their filesystem layout to make it easier to see if any were missed

@react-sizebot
Copy link

Comparing: 556a087...2a82da3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.83 kB 168.83 kB = 52.71 kB 52.71 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.64 kB 170.64 kB = 53.24 kB 53.24 kB
facebook-www/ReactDOM-prod.classic.js = 590.71 kB 590.71 kB = 103.88 kB 103.88 kB
facebook-www/ReactDOM-prod.modern.js = 566.64 kB 566.64 kB = 100.07 kB 100.07 kB
oss-experimental/react-dom/client.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-experimental/react-dom/profiling.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-experimental/react-dom/server.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-experimental/react-dom/static.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-experimental/react-dom/unstable_testing.react-server.js +∞% 0.00 kB 0.11 kB +∞% 0.00 kB 0.12 kB
oss-stable-semver/react-dom/client.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable-semver/react-dom/profiling.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable-semver/react-dom/server.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable-semver/react-dom/static.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable-semver/react-dom/unstable_testing.react-server.js +∞% 0.00 kB 0.11 kB +∞% 0.00 kB 0.12 kB
oss-stable/react-dom/client.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable/react-dom/profiling.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable/react-dom/server.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable/react-dom/static.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable/react-dom/unstable_testing.react-server.js +∞% 0.00 kB 0.11 kB +∞% 0.00 kB 0.12 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/client.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-experimental/react-dom/profiling.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-experimental/react-dom/server.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-experimental/react-dom/static.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-experimental/react-dom/unstable_testing.react-server.js +∞% 0.00 kB 0.11 kB +∞% 0.00 kB 0.12 kB
oss-stable-semver/react-dom/client.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable-semver/react-dom/profiling.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable-semver/react-dom/server.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable-semver/react-dom/static.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable-semver/react-dom/unstable_testing.react-server.js +∞% 0.00 kB 0.11 kB +∞% 0.00 kB 0.12 kB
oss-stable/react-dom/client.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable/react-dom/profiling.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable/react-dom/server.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable/react-dom/static.react-server.js +∞% 0.00 kB 0.10 kB +∞% 0.00 kB 0.11 kB
oss-stable/react-dom/unstable_testing.react-server.js +∞% 0.00 kB 0.11 kB +∞% 0.00 kB 0.12 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 2a82da3

@gnoff gnoff merged commit acef2f8 into facebook:main Apr 8, 2024
37 of 38 checks passed
@gnoff gnoff deleted the missing-files branch April 8, 2024 22:49
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
@gnoff @rickhanlonii
[DOM] Fix package.json files for #28784 (#28785)
dd990fd 
Missed some files for the react-server disallow client change in #28784
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
@gnoff @rickhanlonii
[DOM] Fix package.json files for #28784 (#28785)
87cf97e 
Missed some files for the react-server disallow client change in #28784
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gnoff @AndyPengc12
[DOM] Fix package.json files for facebook#28784 (facebook#28785)
01f1c07 
Missed some files for the react-server disallow client change in facebook#28784
This was referenced Apr 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnoff @react-sizebot @facebook-github-bot