[Tests][Fizz] Test script runtime even when external runtime is available #28794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 7f93cb4...2269a71 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
gnoff
changed the title
gnoff
changed the title
…runtime is unstable and should not be part of stable builds and we should still be testing the integrated Fizz runtime. This change forks the Float tests to ensure we test with and without the external Fizz runtime
acdlite
approved these changes
Apr 9, 2024
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 11, 2024
…able (#28794) Previously if the external runtime was enabled Fizz tests would use it exclusively. However now that this flag is enabled for OSS and Meta builds this means we were no longer testing the inline script runtime. This changes the test flags to produce some runs where we test the inline script runtime and others where we test the external runtime the external runtime will be tested if the flag is enabled and * Meta Builds: variant is true * OSS Builds: experiemental is true this gives us decent coverage. long term we should probably bring variant to OSS builds since we will eventually want to test both modes even when the external runtime is stable.
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 11, 2024
…able (#28794) Previously if the external runtime was enabled Fizz tests would use it exclusively. However now that this flag is enabled for OSS and Meta builds this means we were no longer testing the inline script runtime. This changes the test flags to produce some runs where we test the inline script runtime and others where we test the external runtime the external runtime will be tested if the flag is enabled and * Meta Builds: variant is true * OSS Builds: experiemental is true this gives us decent coverage. long term we should probably bring variant to OSS builds since we will eventually want to test both modes even when the external runtime is stable.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…able (facebook#28794) Previously if the external runtime was enabled Fizz tests would use it exclusively. However now that this flag is enabled for OSS and Meta builds this means we were no longer testing the inline script runtime. This changes the test flags to produce some runs where we test the inline script runtime and others where we test the external runtime the external runtime will be tested if the flag is enabled and * Meta Builds: variant is true * OSS Builds: experiemental is true this gives us decent coverage. long term we should probably bring variant to OSS builds since we will eventually want to test both modes even when the external runtime is stable.
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if the external runtime was enabled Fizz tests would use it exclusively. However now that this flag is enabled for OSS and Meta builds this means we were no longer testing the inline script runtime. This changes the test flags to produce some runs where we test the inline script runtime and others where we test the external runtime
the external runtime will be tested if the flag is enabled and
this gives us decent coverage. long term we should probably bring variant to OSS builds since we will eventually want to test both modes even when the external runtime is stable.