Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Current Owner (and Cache) to an Async Dispatcher #28798

Closed
wants to merge 10 commits into from
Closed

Move Current Owner (and Cache) to an Async Dispatcher #28798

wants to merge 10 commits into from

Commits on Apr 23, 2024

  1. Rename CacheDispatcher to AsyncDispatcher

    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f04709c View commit details
    Browse the repository at this point in the history

  2. Add getOwner on the AsyncDispatcher

    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    286c883 View commit details
    Browse the repository at this point in the history

  3. Rename Cache files to AsyncDispatcher

    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    15bbf6c View commit details
    Browse the repository at this point in the history

  4. Push the async dispatcher if either feature is used for this flag 

    Basically always but we currently don't actually need it for prod on the
client.
    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1222c92 View commit details
    Browse the repository at this point in the history

  5. Track currentOwner for Fiber locally inside the reconciler 

    This means that usage internal to the reconciler can refer to it directly
without going through the dispatcher.
    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7b38ce3 View commit details
    Browse the repository at this point in the history

  6. Same thing for Flight 

    This will later use AsyncLocalStorage to track this just like the cache.
    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b762b1d View commit details
    Browse the repository at this point in the history

  7. Get owner from the dispatcher in JSX 

    We need to be careful about only getting it in branches that has the dispatcher
activated and if the dispatcher is activate.
    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    701c81c View commit details
    Browse the repository at this point in the history

  8. Update tests of the internal states

    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f21097f View commit details
    Browse the repository at this point in the history

  9. Remove old field from internals

    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    197914e View commit details
    Browse the repository at this point in the history

  10. Resolve cycle

    @sebmarkbage
    sebmarkbage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fac727f View commit details
    Browse the repository at this point in the history