Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the react-interactions project which is unused #28799

Merged
merged 1 commit into from Apr 10, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 9, 2024

Removes the react-interactions project which is unused

This project uses unstable_createEventHandle which is being removed from React in version 19

@react-sizebot
Copy link

Comparing: bf40b02...fae8853

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.09 kB 168.09 kB = 52.71 kB 52.71 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 169.90 kB 169.90 kB = 53.25 kB 53.25 kB
facebook-www/ReactDOM-prod.classic.js = 589.45 kB 589.45 kB = 103.79 kB 103.79 kB
facebook-www/ReactDOM-prod.modern.js = 565.29 kB 565.29 kB = 99.92 kB 99.92 kB
test_utils/ReactAllWarnings.js Deleted 64.02 kB 0.00 kB Deleted 15.94 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.02 kB 0.00 kB Deleted 15.94 kB 0.00 kB

Generated by 🚫 dangerJS against fae8853

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 9, 2024
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnoff gnoff merged commit a8a83f7 into facebook:main Apr 10, 2024
38 checks passed
@gnoff gnoff deleted the delete-react-interactions branch April 10, 2024 16:18
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Removes the react-interactions project which is unused

This project uses `unstable_createEventHandle` which is being removed
from React in version 19
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Removes the react-interactions project which is unused

This project uses `unstable_createEventHandle` which is being removed
from React in version 19
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Removes the react-interactions project which is unused

This project uses `unstable_createEventHandle` which is being removed
from React in version 19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants