Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] add assertLog for legacy mode tests #28814

Merged
merged 1 commit into from Apr 10, 2024

Conversation

rickhanlonii
Copy link
Member

A few more tests for #28737

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 10, 2024
@react-sizebot
Copy link

Comparing: bf09089...9cd95fa

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.12 kB 168.12 kB = 52.72 kB 52.72 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 169.92 kB 169.92 kB = 53.26 kB 53.26 kB
facebook-www/ReactDOM-prod.classic.js = 588.50 kB 588.50 kB = 103.50 kB 103.50 kB
facebook-www/ReactDOM-prod.modern.js = 564.35 kB 564.35 kB = 99.66 kB 99.66 kB
test_utils/ReactAllWarnings.js Deleted 64.24 kB 0.00 kB Deleted 16.03 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.24 kB 0.00 kB Deleted 16.03 kB 0.00 kB

Generated by 🚫 dangerJS against 9cd95fa

@rickhanlonii rickhanlonii merged commit 870e404 into facebook:main Apr 10, 2024
38 checks passed
@rickhanlonii rickhanlonii deleted the rh/assert-legacy-mode branch April 10, 2024 18:02
rickhanlonii added a commit that referenced this pull request Apr 11, 2024
rickhanlonii added a commit that referenced this pull request Apr 11, 2024
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants