Remove flight-browser fixture
#28828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds which are now removed so we'd have to make it use esm.sh or something and really it just won't work because it needs to be built by webpack to not error. We could potentially shim the webpack globals but really the right thing is to publish the esm version of react-server and use esm.sh to load a browser only esm demo of react-server. This change removes the flight-browser fixtures
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: c8a0350...386ffb3 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
approved these changes
Apr 12, 2024
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
The flight-browser fixtures doesn't make sense. It also uses UMD builds which are being removed so we'd have to make it use esm.sh or something and really it just won't work because it needs to be built by webpack to not error. We could potentially shim the webpack globals but really the right thing is to publish the esm version of react-server and use esm.sh to load a browser only esm demo of react-server. This change removes the flight-browser fixture
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flight-browser fixtures doesn't make sense. It also uses UMD builds which are being removed so we'd have to make it use esm.sh or something and really it just won't work because it needs to be built by webpack to not error. We could potentially shim the webpack globals but really the right thing is to publish the esm version of react-server and use esm.sh to load a browser only esm demo of react-server. This change removes the flight-browser fixture