Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console test utils fix: match entire string, not just first letter #28855

Merged
merged 2 commits into from
Apr 17, 2024
Merged

console test utils fix: match entire string, not just first letter #28855

merged 2 commits into from
Apr 17, 2024

Commits on Apr 17, 2024

  1. console test utils fix: match entire string 

    Fixes issue where if the first letter of the expected string appeared
anywhere in actual message, the assertion would pass, leading to
false negatives. We should check the entire expected string.
    @acdlite
    acdlite committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ccf7cc8 View commit details
    Browse the repository at this point in the history

  2. Typo: complete -> completely 

    Co-authored-by: Ricky <rickhanlonii@gmail.com>
    @acdlite @rickhanlonii
    acdlite and rickhanlonii committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6e1aaa1 View commit details
    Browse the repository at this point in the history