Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "convert circleci workflow devtools_regression_tests to github actions" #28865

Merged

Conversation

rickhanlonii
Copy link
Member

Reverts #27800, tests fail on main

@rickhanlonii rickhanlonii merged commit 4fdbac0 into main Apr 18, 2024
1 of 23 checks passed
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Apr 18, 2024
@react-sizebot
Copy link

Comparing: 496e873...99f06a1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.91 kB 168.91 kB = 52.94 kB 52.94 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.57 kB 170.57 kB = 53.44 kB 53.44 kB
facebook-www/ReactDOM-prod.classic.js = 590.83 kB 590.83 kB = 103.91 kB 103.91 kB
facebook-www/ReactDOM-prod.modern.js = 566.65 kB 566.65 kB = 100.10 kB 100.10 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Generated by 🚫 dangerJS against 99f06a1

@rickhanlonii rickhanlonii deleted the revert-27800-cci2actions-devtools-regression-tests branch April 18, 2024 14:27
@Zaid-maker
Copy link

Why not just fix it tho

@rickhanlonii
Copy link
Member Author

It's not clear what the fix is and we need to keep main green.

@Zaid-maker
Copy link

It's not clear what the fix is and we need to keep main green.

Got it! Hope in future got a fix for that ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants