Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Land #28798) Move Current Owner (and Cache) to an Async Dispatcher #28912

Merged
merged 10 commits into from
Apr 25, 2024
Merged

(Land #28798) Move Current Owner (and Cache) to an Async Dispatcher #28912

merged 10 commits into from
Apr 25, 2024

Commits on Apr 25, 2024

  1. Rename CacheDispatcher to AsyncDispatcher

    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6d13208 View commit details
    Browse the repository at this point in the history

  2. Add getOwner on the AsyncDispatcher

    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    348b7e0 View commit details
    Browse the repository at this point in the history

  3. Rename Cache files to AsyncDispatcher

    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ea9c8d7 View commit details
    Browse the repository at this point in the history

  4. Push the async dispatcher if either feature is used for this flag 

    Basically always but we currently don't actually need it for prod on the
client.
    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b6996c5 View commit details
    Browse the repository at this point in the history

  5. Track currentOwner for Fiber locally inside the reconciler 

    This means that usage internal to the reconciler can refer to it directly
without going through the dispatcher.
    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    399b0cb View commit details
    Browse the repository at this point in the history

  6. Same thing for Flight 

    This will later use AsyncLocalStorage to track this just like the cache.
    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    95b36e1 View commit details
    Browse the repository at this point in the history

  7. Get owner from the dispatcher in JSX 

    We need to be careful about only getting it in branches that has the dispatcher
activated and if the dispatcher is activate.
    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    deb2aae View commit details
    Browse the repository at this point in the history

  8. Update tests of the internal states

    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    af3c909 View commit details
    Browse the repository at this point in the history

  9. Remove old field from internals

    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6acd079 View commit details
    Browse the repository at this point in the history

  10. Resolve cycle

    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7671621 View commit details
    Browse the repository at this point in the history