Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] render boundary in fallback if it contains a new stylesheet during sync update #28965

Merged
merged 1 commit into from
May 21, 2024
Merged

[Fiber] render boundary in fallback if it contains a new stylesheet during sync update #28965

merged 1 commit into from
May 21, 2024

Commits on May 21, 2024

  1. [Fiber] render boundary in fallback if it contains a new stylesheet d… 

    …uring sync update

When we implemented Suspensey CSS we had a heuristic that if the update was sync we would ignore the loading states of any new stylesheets and just do the commit. But for a stylesheet capability to be useful it needs to reliably prevent FOUC and since the stylesheet api is opt-in through precedence we don't have to maintain backaward compat (old stylesheets do not block commit but then nobody really renders them because of FOUC anyway)

This update modifies the logic to put a boundary back into fallback if a sync update would lead to a stylesheet commiting before it loaded.
    @gnoff
    gnoff committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8839e50 View commit details
    Browse the repository at this point in the history