Update getComments.js #29002
Update getComments.js #29002
Conversation
Added two scenarios: 1. Commented starting on the line 20: Created a map of comments by line number. It then uses this map to find the comments on the line before the node at the given path. This should be more efficient than the original function if the number of comments is large and they are not sorted by line number. However, it does require additional memory to store the map. 2. Lines 41 - 47 and commented 48 - 52: We store the line number of the first comment we find that is on the line before the node. We then continue to add comments to the comments array until we find a comment that is not on this line. This optimization reduces the number of iterations in the second while loop, but it doesn't change the overall time complexity of the function. The time complexity is still O(n), where n is the number of comments. This is because in the worst case, we still have to iterate through all the comments.
|
Hi @AnuragKacham! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Please review the changes mentioned. Added two scenarios:
Created a map of comments by line number. It then uses this map to find the comments on the line before the node at the given path. This should be more efficient than the original function if the number of comments is large and they are not sorted by line number. However, it does require additional memory to store the map.
We store the line number of the first comment we find that is on the line before the node. We then continue to add comments to the comments array until we find a comment that is not on this line. This optimization reduces the number of iterations in the second while loop, but it doesn't change the overall time complexity of the function. The time complexity is still O(n), where n is the number of comments. This is because in the worst case, we still have to iterate through all the comments. |
|
Thanks for the PR, but we generally don't take PRs that make small refactors. They very rarely help and usually tend to introduce subtle bugs. Since this only runs for tests, we don't need a micro optimization. |
|
Comparing: 46abd7b...075c19f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Added two scenarios:
Created a map of comments by line number. It then uses this map to find the comments on the line before the node at the given path. This should be more efficient than the original function if the number of comments is large and they are not sorted by line number. However, it does require additional memory to store the map.
We store the line number of the first comment we find that is on the line before the node. We then continue to add comments to the comments array until we find a comment that is not on this line.
This optimization reduces the number of iterations in the second while loop, but it doesn't change the overall time complexity of the function. The time complexity is still O(n), where n is the number of comments. This is because in the worst case, we still have to iterate through all the comments.
Summary
How did you test this change?