fix[ReactDebugHooks/find-primitive-index]: remove some assumptions #29652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: afb2c39...6a0b69c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
approved these changes
May 29, 2024
| // assume that the next frame after that is the actual public API call. | ||
| // This prohibits nesting dispatcher calls in hooks. | ||
| // If the next two frames are functions called `useX` then we assume that they're part of the | ||
| // wrappers that the React packager or other packages adds around the dispatcher. |
There was a problem hiding this comment.
Suggested change
| // wrappers that the React packager or other packages adds around the dispatcher. | |
| // wrappers that the React package or other packages adds around the dispatcher. |
hoxyq
force-pushed
the
react-devtools/fix-find-primitive-index-for-react-native
branch
from
14bdcd3
to
6a0b69c
Compare
hoxyq
deleted the
react-devtools/fix-find-primitive-index-for-react-native
branch
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
…29652) Partially reverts #28593. While rolling out RDT 5.2.0, I've observed some issues on React Native side: hooks inspection for some complex hook trees, like in AnimatedView, were broken. After some debugging, I've noticed a difference between what is in frame's source. The difference is in the top-most frame, where with V8 it will correctly pick up the `Type` as `Proxy` in `hookStack`, but for Hermes it will be `Object`. This means that for React Native this top most frame is skipped, since sources are identical. Here I am reverting back to the previous logic, where we check each frame if its a part of the wrapper, but also updated `isReactWrapper` function to have an explicit case for `useFormStatus` support. DiffTrain build for commit fb61a1b.
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
…29652) Partially reverts #28593. While rolling out RDT 5.2.0, I've observed some issues on React Native side: hooks inspection for some complex hook trees, like in AnimatedView, were broken. After some debugging, I've noticed a difference between what is in frame's source. The difference is in the top-most frame, where with V8 it will correctly pick up the `Type` as `Proxy` in `hookStack`, but for Hermes it will be `Object`. This means that for React Native this top most frame is skipped, since sources are identical. Here I am reverting back to the previous logic, where we check each frame if its a part of the wrapper, but also updated `isReactWrapper` function to have an explicit case for `useFormStatus` support. DiffTrain build for [fb61a1b](fb61a1b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #28593.
While rolling out RDT 5.2.0, I've observed some issues on React Native side: hooks inspection for some complex hook trees, like in AnimatedView, were broken. After some debugging, I've noticed a difference between what is in frame's source.
The difference is in the top-most frame, where with V8 it will correctly pick up the
TypeasProxyinhookStack, but for Hermes it will beObject. This means that for React Native this top most frame is skipped, since sources are identical.Here I am reverting back to the previous logic, where we check each frame if its a part of the wrapper, but also updated
isReactWrapperfunction to have an explicit case foruseFormStatussupport.