Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when using React.unmountComponentAtNode on a different React instance's tree #3819

Closed
wants to merge 1 commit into from
Closed

Warn when using React.unmountComponentAtNode on a different React instance's tree #3819

wants to merge 1 commit into from

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented May 6, 2015

Fixes #3787

@sebmarkbage
Copy link
Collaborator

cc @spicyj for a sanity check

@sebmarkbage sebmarkbage added this to the 0.15 milestone Oct 6, 2015
@sophiebits
Copy link
Collaborator

I don't think this works if the element has a data-reactid attribute, which it would in the case you're trying to catch?

@devknoll devknoll closed this Oct 7, 2015
@ventuno ventuno mentioned this pull request Aug 10, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

Warn when using React.unmountComponentAtNode on a different React instance's tree
5 participants
@devknoll @sebmarkbage @sophiebits @facebook-github-bot @reactjs-bot