Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blessed entry points to isomorphic and dom #4064

Closed
wants to merge 1 commit into from

Conversation

zpao
Copy link
Member

@zpao zpao commented Jun 9, 2015

This adds the following entry points to the npm module

  • react/dom (exposes client and server)
  • react/dom/client
  • react/dom/server
  • react/isomorphic

cc @sebmarkbage

@sophiebits
Copy link
Collaborator

Do you often want both client and server? I'm ignorantly leaning towards not having react/dom.

@sebmarkbage
Copy link
Collaborator

Yea. I think my original naive idea was for react/dom or react-dom to be the client version only while the server would be react/dom/server or react-dom/server or something.

@zpao
Copy link
Member Author

zpao commented Jun 10, 2015

So drop react/dom directly? I think I'd prefer that over having one be a shortcut.

@sebmarkbage
Copy link
Collaborator

sure

@sophiebits
Copy link
Collaborator

bikeshed: is react/dom/browser nicer? "client" sounds weird to me in this context, dunno why.

@zpao
Copy link
Member Author

zpao commented Jun 10, 2015

isomorphic is pretty weird too :P

@zpao
Copy link
Member Author

zpao commented Jun 11, 2015

Updated. Left as server & client.

@sophiebits
Copy link
Collaborator

Not a fan of "browser"? I also might like "core" over "isomorphic" if we think that's an accurate descriptor.

@sebmarkbage
Copy link
Collaborator

"browser" is too ambiguous. canvas, webgl, three.js, art, a theoretical react-native for web etc... They're all browser.

@zpao zpao mentioned this pull request Jun 11, 2015
@zpao
Copy link
Member Author

zpao commented Jun 15, 2015

closing in favor of #4097

@zpao zpao closed this Jun 15, 2015
@zpao zpao deleted the package-updates branch June 16, 2015 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants