Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CSS3 Grid Layout Module for inline styles #4779

Merged
merged 1 commit into from Oct 7, 2015

Conversation

Projects
None yet
5 participants
@mnordick
Copy link

commented Sep 3, 2015

The gridRow and gridColumn styles are numerical but should be treated as unitless. Currently React is appending the px suffix causing them to be invalid.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Sep 3, 2015

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Sep 3, 2015

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@probablyup

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2015

@mnordick You should rebase against master to remove the merge commit.

Mike Nordick Mike Nordick
Adding support for CSS3 Grid layout module.
grid-row and grid-column must be unitless numbers.

@mnordick mnordick force-pushed the mnordick:master branch from 051638e to 8da4efa Sep 10, 2015

@mnordick

This comment has been minimized.

Copy link
Author

commented Sep 10, 2015

@yaycmyk Done.

@sebmarkbage sebmarkbage added this to the 0.15 milestone Oct 6, 2015

sophiebits added a commit that referenced this pull request Oct 7, 2015

Merge pull request #4779 from mnordick/master
Support CSS3 Grid Layout Module for inline styles

@sophiebits sophiebits merged commit 4a29fd8 into facebook:master Oct 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.