Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fast_finish in travis.yml. #5721

Merged
merged 1 commit into from
Dec 23, 2015
Merged

Remove fast_finish in travis.yml. #5721

merged 1 commit into from
Dec 23, 2015

Conversation

jdalton
Copy link
Contributor

@jdalton jdalton commented Dec 23, 2015

I noticed a fast_finish entry in the travis.yml.
I hadn't seen that option before and looked it up.

It seems to only apply if you allow_failures which I don't see in the yml.

@zpao
Copy link
Member

zpao commented Dec 23, 2015

Thanks! That was there because we used to allow some of those pesky in-browser tests to fail and I missed this option when removing them in your favorite PR :P (https://github.com/facebook/react/pull/4393/files#diff-354f30a63fb0907d4ad57269548329e3)

zpao added a commit that referenced this pull request Dec 23, 2015
Remove fast_finish in travis.yml.
@zpao zpao merged commit 56365f4 into facebook:master Dec 23, 2015
@jdalton
Copy link
Contributor Author

jdalton commented Dec 23, 2015

FWIW I've been able to get pretty stable tests using saucelabs for nearly 2 years now.
The thing that made it work, which can be applied to any remote testing setup/service, is adding in levels of retries. From retrying the async test in QUnit, to retrying a faulty test run from sauce, to retrying the sauce tunnel connection. With those in place, I hardly ever have false fails.

@jdalton jdalton deleted the fast-finish branch December 23, 2015 19:48
@zpao
Copy link
Member

zpao commented Dec 23, 2015

I remember seeing something about that a while ago, so thanks for the reminder. We'll keep that in mind and probably crib from lodash whenever #5703 gets done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants