Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable null return values in plain functions #5884

Merged
merged 1 commit into from Jan 29, 2016

Conversation

Projects
None yet
6 participants
@jimfb
Copy link
Contributor

commented Jan 19, 2016

Enable null return values in plain functions by removing support for inheritless classes, as per #5355.

@jimfb jimfb added this to the 0.15 milestone Jan 19, 2016

@sebmarkbage sebmarkbage referenced this pull request Jan 19, 2016

Closed

Umbrella 15.0 #4600

5 of 7 tasks complete

@jimfb jimfb force-pushed the jimfb:component-extends-react-component branch from d8ef46a to d32aee5 Jan 19, 2016

@jimfb

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2016


it('should allow simple functions to return false', function() {
function Child() {
return null;

This comment has been minimized.

Copy link
@zpao

zpao Jan 20, 2016

Member

false

@jimfb jimfb force-pushed the jimfb:component-extends-react-component branch from d32aee5 to 757756f Jan 20, 2016

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jan 20, 2016

@jimfb updated the pull request.

@jquense

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2016

🙌

@jimfb

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2016

@sophiebits

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2016

I thought I reviewed this already. 👍

jimfb added a commit that referenced this pull request Jan 29, 2016

Merge pull request #5884 from jimfb/component-extends-react-component
Enable null return values in plain functions

@jimfb jimfb merged commit 188e8cd into facebook:master Jan 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sophiebits sophiebits referenced this pull request Feb 9, 2016

Merged

Enable module pattern. #6008

@martiros

This comment has been minimized.

Copy link

commented Feb 24, 2016

👍

afc163 added a commit to react-component/table that referenced this pull request Aug 2, 2016

gaearon added a commit to gaearon/react that referenced this pull request Dec 28, 2016

Remove a duplicate test
This test is identical to "should warn when stateless component returns array" earlier.

It was moved from another file in facebook#5884 so it likely survived by accident.

gaearon added a commit to gaearon/react that referenced this pull request Dec 28, 2016

Remove unnecessary warning for invalid node
We have an invariant that checks the same case right afterwards.

The warning was originally added in facebook#5884 with a distinct wording.

However it was later changed to the same wording as the invariant in facebook#6008.

I don't see why we would want to have both since they're saying the same thing and with (almost) the same internal stack.

acdlite added a commit to acdlite/react that referenced this pull request Jan 12, 2017

Remove a duplicate test
This test is identical to "should warn when stateless component returns array" earlier.

It was moved from another file in facebook#5884 so it likely survived by accident.

acdlite added a commit to acdlite/react that referenced this pull request Jan 12, 2017

Remove unnecessary warning for invalid node
We have an invariant that checks the same case right afterwards.

The warning was originally added in facebook#5884 with a distinct wording.

However it was later changed to the same wording as the invariant in facebook#6008.

I don't see why we would want to have both since they're saying the same thing and with (almost) the same internal stack.

@yuit yuit referenced this pull request Jan 27, 2017

Merged

[React] Allow SFC to return null #14284

7 of 10 tasks complete

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.