docs remove rootNode for componentDidMount/Update #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this change :) |
|
@zpao added the Note. Screwed up the other commit so submitting a new one here. |
| ``` | ||
|
|
||
| Invoked immediately after updating occurs. This method is not called for the initial render. | ||
|
|
||
| Use this as an opportunity to operate on the DOM when the component has been updated. | ||
|
|
||
| > Note: | ||
| > | ||
| > Until v0.5, The parameter `rootNode` was passed to this method as a shortcut to `this.getDOMNode()`. |
There was a problem hiding this comment.
"Until" isn't the right word here. At least the way I understand that, it means it stopped working in 0.5, which isn't true. Maybe just s/0.5/0.6/. Also, "The" shouldn't be capitalized. But also also, the name of the parameter isn't important. I would instead say something like "Prior to v0.6, the DOM node was passed in as the final argument. If you were using this, you can still access the DOM node by calling this.getDOMNode()."
There was a problem hiding this comment.
I'll just take your wording sentence lol
zpao
added a commit
that referenced
this pull request
Nov 28, 2013
docs remove rootNode for componentDidMount/Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.