Fix race condition in ResponderTouchHistoryStore #6278
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a cold boot of my React Native app, if the first touch on the screen is a scroll on a ListView/ScrollView, there appears to be a race condition and
recordMoveTouchData
is called beforerecordStartTouchData
, thereforetouchHistory.touchBank
is not properly initialized.Upon the first call,
var touchTrack = touchBank[touch.identifier];
touchTrack is undefined here, causing the crash. This code change resolves the problem by properly initializing the touchBank. Not sure if this is the correct approach, because it's probably an indication of a deeper problem, but wanted to start a conversation about it.