Fix scrollLeft/scrollTop warning in latest Chrome #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome gives the warnings ``` body.scrollLeft is deprecated in strict mode. Please use 'documentElement.scrollLeft' if in strict mode and 'body.scrollLeft' only if in quirks mode. body.scrollTop is deprecated in strict mode. Please use 'documentElement.scrollTop' if in strict mode and 'body.scrollTop' only if in quirks mode. ``` the first time getUnboundedScrollPosition is invoked. This fixes it. (All modern browsers support `pageYOffset`; IE 8 doesn't but works properly with `document.documentElement.scrollTop` except in quirks mode which React doesn't support.)
|
Who should review this code? |
|
Perhaps yungsters or you could do a blame on getUnboundedScrollPosition.js internally. |
ghost
assigned 
|
I think previous versions of WebKit (and Chrome) returned I've tested this on Safari, Firefox, Chrome, and IE 8+. Looks good to me, thanks for investigating and fixing. |
yungsters
added a commit
that referenced
this pull request
Jan 6, 2014
Fix scrollLeft/scrollTop warning in latest Chrome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome gives the warnings
the first time getUnboundedScrollPosition is invoked. This fixes it. (All modern browsers support
pageYOffset; IE 8 doesn't but works properly withdocument.documentElement.scrollTopexcept in quirks mode which React doesn't support.)cc @yungsters (by the way, it looks like
getDocumentScrollElementcan be implemented by checkingdocument.documentElement.clientWidth > 0. but do you needgetDocumentScrollElementat all in FB code? it should returndocument.bodyonly in quirks mode.)