Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component instance to ReactDebugTool's onStateUpdated #6482

Closed
wants to merge 3 commits into from

Conversation

omerts
Copy link

@omerts omerts commented Apr 11, 2016

For sniffing state, it would be nice to actually get the component instance that has raised the onSetState event using ReactDebugTool

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Apr 11, 2016

Hi, thank you for the pull request! I agree this is useful, but there is a work in progress on a special introspection API (#6389, extracted from #6046, and more to follow) that is aimed at providing introspection capabilities like this without exposing internal instances.

#6389 contains more details about the plan. I’ll close this PR as we don’t want to expose the internal instances in the new API (at least we’ll try not to). However I think we’ll be happy to take a contribution that adds something like getState(instanceID) to ReactDebugIntrospection after it lands (in a few weeks).

Cheers!

@gaearon gaearon closed this Apr 11, 2016
@omerts
Copy link
Author

omerts commented Apr 11, 2016

@gaearon Thanks for the detailed answer. Waiting for the update :)
By the way, we need this because we are working on actually replaying inner component states using the redux dev-tools extension ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants