Add xmlNS and xmlnsXlink SVG Attributes #6532
Conversation
- Since is a good practice to include all the commonly used namespace declarations when creating `<svg>`, specially when used as external `.svg` files to help the users agents recognize the content, it is necessary to have at least those attributes available. - Change the `xml` namespace into the String standard most used.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
| @@ -264,7 +264,9 @@ var ATTRS = { | |||
| xlinkType: 'xlink:type', | |||
| xmlBase: 'xml:base', | |||
| xmlLang: 'xml:lang', | |||
| xmlNS: 'xmlns', | |||
There was a problem hiding this comment.
It appears like the capitalization only happens after a :. Is there any reason to break that pattern here?
There was a problem hiding this comment.
You are right @iamdustan, capitalisation happens after : or - and this attribute (xmlns) seems to be al little weird (but this is a spec problem). I just followed the point 3 from this comment and seems coherent to me.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Sorry for the delay! Going to take #6471 instead. I think the change to the XML namespace is actually incorrect. We use that for the XML attributes which don't get created in the SVG namespace. |
<svg>, specially when used as external.svgfiles to help the users agents recognise the content, it is necessary to have at least those attributes available.xmlnamespace into the String standard most used.Specify syntax and change
xmlnamespace based on #6471