Add support for movementX/Y in SyntheticMouseEvent #6727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Register screenX/Y after calculating values Fix movementY variable name error Linting fix Return 0 in instanes where previous values are null
|
@aweary updated the pull request. |
|
I'll go ahead and close this out since it's never been reviewed and is out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6723
So there's still work that needs to be done here, but I wanted to open the PR so I could get feedback early on. I have a couple questions:
movementX/movementYyou need the previous mouse event'sscreenX/screenY. I implemented aMouseMetricshere similar toViewportMetrics. Is that the right approach?1a. If
MouseMetricsis an acceptable, is there a better place in the code path where I should register the newpreviousScreen{X,Y}values?SyntheticMouseEvents, am I just not seeing them or do they not exist? Where should I add tests for this?