Maybe fix IE autocomplete misses #6806
Conversation
Quick attempt to fix #6614 I HAVE NOT TESTED THIS, needs someone to confirm it actually works instead of creating an endless event loop It listens for the top level onChange, which is a bit dangerous (maybe?) since the other events will fire a top level Change event, Presumably tho the value won’t differ and it will be a loop. Alternatively we could listen to onInput but you might get the noise again, depending on how well the deduping is working
|
cc @arendjr |
ghost
added
|
I'm afraid it doesn't fix it for me... |
|
Can you confirm you've built correctly and the code above is running in your browser (in the dev tools you can check). Do you have a sense as to why its not working? its now listening for the onChange. does the code get to that branch on an autocomplete? |
|
I did confirm the correct code was running in the browser, but I'm not sure why it's failing. Indeed I confirmed earlier the change event should've been triggered by the auto-complete. If I got time I'll try to take a deeper look tomorrow. |
|
Yes, I can confirm a manual DOM event listener for the "change" event fires, but "onChange" isn't called. |
|
It seems that its not straightforward to fix some of these b/c they require focus. gonna close, sicne its already fixed in master anyway |
Quick attempt to fix #6614
I HAVE NOT TESTED THIS, needs someone to confirm it actually works
instead of creating an endless event loop
It listens for the top level onChange, which is a bit dangerous
(maybe?) since the other events will fire a top level Change event,
Presumably tho the value won’t differ and it will be a loop.
Alternatively we could listen to onInput but you might get the noise
again, depending on how well the deduping is working