Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper render method in static markup event listener test #7652

Merged
merged 1 commit into from Sep 3, 2016

Conversation

nhunzaker
Copy link
Contributor

The renderToStaticMarkup test that checks for event listeners was using the wrong render method.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.233% when pulling e9e101b on nhunzaker:nh-static-markup-test into 7b247f3 on facebook:master.

@gaearon gaearon merged commit 40c90a6 into facebook:master Sep 3, 2016
@gaearon gaearon added this to the 15-next milestone Sep 3, 2016
@gaearon
Copy link
Collaborator

gaearon commented Sep 3, 2016

Thanks.

@fson
Copy link
Contributor

fson commented Sep 3, 2016

There's a couple of other calls to renderToString left inside the describe('renderToStaticMarkup') block:

Not sure if they should be testing renderToStaticMarkup instead, or if they should be defined in a different place in the file?

@gaearon
Copy link
Collaborator

gaearon commented Sep 3, 2016

Need to ask the authors.

acdlite pushed a commit to acdlite/react that referenced this pull request Sep 9, 2016
@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
zpao pushed a commit that referenced this pull request Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants