Fix ReactDOMFiberSelect to set the initial values #8349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot that the normal properties route doesn't do this. We also have to make sure that the order is 1) insert children (options), 2) set multiple 3) update the options.
|
k |
sebmarkbage
force-pushed
the
fiberdom
branch
from
439b844
to
11db613
Compare
sophiebits
reviewed
Nov 18, 2016
| @@ -153,6 +153,13 @@ var ReactDOMSelect = { | |||
| ); | |||
| didWarnValueDefaultValue = true; | |||
| } | |||
|
|
|||
| node.multiple = Boolean(props.multiple); | |||
| if (value != null) { | |||
There was a problem hiding this comment.
nit: inconsistent style between value/defaultValue
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
I forgot that the normal properties route doesn't do this. We also have to make sure that the order is 1) insert children (options), 2) set multiple 3) update the options.
This was referenced Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that the normal properties route doesn't do this. We also have to make sure that the order is 1) insert children (options), 2) set multiple 3) update the options.