Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Add ReactDOMFiber.unstable_createPortal() #8386

Merged
merged 2 commits into from
Nov 22, 2016
Merged

[Fiber] Add ReactDOMFiber.unstable_createPortal() #8386

merged 2 commits into from
Nov 22, 2016

Commits on Nov 22, 2016

  1. [Fiber] Add ReactDOMFiber.unstable_createPortal() 

    While facebook#8368 added a version of `ReactDOM.unstable_renderSubtreeIntoContainer()` to Fiber, it is a bit hacky and, more importantly, incompatible with Fiber goals. Since it encourages performing portal work in lifecycles, it stretches the commit phase and prevents slicing that work, potentially negating Fiber benefits.

This PR adds a first version of a declarative API meant to replace `ReactDOM.unstable_renderSubtreeIntoContainer()`. The API is a declarative way to render subtrees into DOM node containers.
    @gaearon
    gaearon committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    b58fd28 View commit details
    Browse the repository at this point in the history

  2. Remove hacks related to output field

    @gaearon
    gaearon committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    82913d4 View commit details
    Browse the repository at this point in the history