Finish ReactGenericBatching #8405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
commented
Nov 24, 2016
| src/renderers/dom/shared/__tests__/ReactEventListener-test.js | ||
| * should batch between handlers from different roots | ||
| src/renderers/dom/shared/wrappers/__tests__/ReactDOMInput-test.js | ||
| * should control a value in reentrant events |
There was a problem hiding this comment.
This fails but if restoreStateOfTarget gets the right props (in this case, from the alternate) then it passes.
There was a problem hiding this comment.
I don't quite understand this. Why is this failing now? Are we waiting for another fix?
There was a problem hiding this comment.
Before the updates weren't getting batched so the setState calls had different behavior. The test fails because the props here aren't correct and there is a TODO to fix it:
It looks like luck that the test passed before.
sebmarkbage
approved these changes
Nov 24, 2016
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.