Move React Native Environment Mocks to root #8963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These mocks are things we expect to be available in the React Native environment. I'd like to move them out of the renderer folder so that we can sync that folder to React Native as is without overriding its mocks. I motivate by the fact that they're not really part of the renderer code itself. I leave the ReactNative mock since that is in fact part of the renderer.
|
Landing this to unblock your sync (I'll cut another alpha now). |
This was referenced Jun 24, 2023
facebook-github-bot
added
the
React Core Team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mocks are things we expect to be available in the React Native environment. I'd like to move them out of the renderer folder so that we can sync that folder to React Native as is without overriding its mocks.
I motivate by the fact that they're not really part of the renderer code itself. I leave the ReactNative mock since that is in fact part of the renderer.